Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #2468, we removed our grpc call to decodeRawTransactions.
When working at #2516, I noticed we are not properly decoding sstxcommitment scripts, which are needed for signing the tx message for the vsp.
This PR adds it.
Diff description:
helpers/script.js
I am adding theparseScript
method, which was removed from dcrd due to optmizations at the txscript on txscript: Zero alloc optimization refactor. dcrd#1656.addrFromSStxPkScrCommitment
so we can get addressses from sstxcommitment scriptswallet/service.spec.js
which is a integration test of ourdecodeRawTransaction
methods from wallet service. It is in unit tests because right now our package.json consider our unit/test folder as test's rootDir. We need to add integration tests to it.